Add final name "Crime-Database"#59
Merged
Merged
Conversation
Contributor
|
When adding the final name, maybe we should update the dockerfile as well? (So it works :) ) |
Contributor
|
Do we need a final name? And is there another way to implement it in Spring Boot? I get the feeling this is not the right way? OR did we talk about this during class? |
Contributor
Author
Contributor
Contributor
|
The docker file uses "CrimeDatabase-0.0.1-SNAPSHOT.jar ", which we will have to change during the lifetime of the application (When we make a release we will remove SNAPSHOT and then increase the number). If we have a final name we don't have to remember to update the dockerfil each time we update the version of the project :) |
LordRekishi
requested changes
Mar 18, 2022
LordRekishi
approved these changes
Mar 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix #51
Adding final name in pom.xml