Skip to content

Add final name "Crime-Database"#59

Merged
LordRekishi merged 4 commits into
mainfrom
Issue51-finalname
Mar 18, 2022
Merged

Add final name "Crime-Database"#59
LordRekishi merged 4 commits into
mainfrom
Issue51-finalname

Conversation

@FelixJacobsen

Copy link
Copy Markdown
Contributor

Fix #51

Adding final name in pom.xml

@helenahalldiniths

Copy link
Copy Markdown
Contributor

When adding the final name, maybe we should update the dockerfile as well? (So it works :) )

@LordRekishi

Copy link
Copy Markdown
Contributor

Do we need a final name? And is there another way to implement it in Spring Boot? I get the feeling this is not the right way? OR did we talk about this during class?

@FelixJacobsen

Copy link
Copy Markdown
Contributor Author

Finalname has nothing to do with Spring boot I think, it's more to have a static name for deployment/tests?

image

@LordRekishi

Copy link
Copy Markdown
Contributor

Finalname has nothing to do with Spring boot I think, it's more to have a static name for deployment/tests?

image

Should it be scrapped then? Do we get any benefit from it?

@helenahalldiniths

Copy link
Copy Markdown
Contributor

The docker file uses "CrimeDatabase-0.0.1-SNAPSHOT.jar ", which we will have to change during the lifetime of the application (When we make a release we will remove SNAPSHOT and then increase the number). If we have a final name we don't have to remember to update the dockerfil each time we update the version of the project :)

Comment thread pom.xml Outdated
@LordRekishi LordRekishi merged commit 4334172 into main Mar 18, 2022
@LordRekishi LordRekishi deleted the Issue51-finalname branch March 18, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add final name for project

3 participants