Exception#44
Conversation
|
I accedently markt this as ready for review, my bad! |
helenahalldiniths
left a comment
There was a problem hiding this comment.
I have looked throught the code and it looks good. However, the Victim-class is missing som error handling
|
I think this is ok! I will look at the "exceptions" videos when I get a chance and after that I can do a final review! |
… to use Object "It is highly recommended not to use wildcard types as return types".
helenahalldiniths
left a comment
There was a problem hiding this comment.
I've made some small changes, but overall it looks good.
My only thaught is that maybe we shouldn't throw an exception when "findAll" returns an empty list? If there are no entitys an empty list is a correct response! What do you think?
|
Tips on inprovment later on: In GlobalExceptionHandler:
|
Sounds good. You making some "enhancement" issues and putting them further down the line? |
LordRekishi
left a comment
There was a problem hiding this comment.
I just made comments on Address, but it applies to all controllers.
Fix #11
Includes three custom exceptions. MethodNotAllowed exception needs to be implemented after update methods have been created in all controller and service classes.