Add dockerfile#43
Merged
Merged
Conversation
helenahalldiniths
approved these changes
Mar 14, 2022
Contributor
There was a problem hiding this comment.
Works fine!
I added a short discription of how to run it (in README.md). I think it's better to rewrite the deployment part later on (when we change it) but always try to keep it up to date :) Feels good to have it documented somewere, if we don't remember the commands but want to run it as it is :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #28
I've decided not to make any changes in the README.md because I'm not sure how they will look like depending how we use JMS and which implementation of JMS we decide to use.
Here is an example on how Docker-RabbitMQ instructions can look like:
https://github.com/puckel/docker-rabbitmq/blob/master/README.md
They are abit more advanced than I expected and I therefore think we should make it in a separate issue.