Create maven.yml#31
Merged
Merged
Conversation
Contributor
Author
|
The default test class throws an error (java.lang.IllegalStateException) when you try to run it. I will read a little bit more about spring boot tests and try to fix it. However, I think that the maven.yml file works fine. |
FelixJacobsen
approved these changes
Mar 9, 2022
FelixJacobsen
left a comment
Contributor
There was a problem hiding this comment.
From what I can tell this file looks good! If I remember correctly you made this file in our fungover project so I suspect you are an expert on maven.yml files at this point :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix #29
I renamed the branch from issue209 to issue29. This resulted in me having to create a new pull request