Skip to content

Crime#23

Merged
helenahalldiniths merged 4 commits into
mainfrom
crime
Mar 8, 2022
Merged

Crime#23
helenahalldiniths merged 4 commits into
mainfrom
crime

Conversation

@LordRekishi

Copy link
Copy Markdown
Contributor

Fix #3

@FelixJacobsen FelixJacobsen self-requested a review March 8, 2022 14:50
@helenahalldiniths helenahalldiniths self-requested a review March 8, 2022 17:04

@helenahalldiniths helenahalldiniths left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
In the draft we hade a field for location ("plats"). I think we can add it later on if we want, this looks good for now!

@helenahalldiniths helenahalldiniths self-requested a review March 8, 2022 17:17

@helenahalldiniths helenahalldiniths left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized you are using IntelliJ standard getters and setters (and not the setter template "build"). I think we should use the same for the hole project.

@LordRekishi

Copy link
Copy Markdown
Contributor Author

I just realized you are using IntelliJ standard getters and setters (and not the setter template "build"). I think we should use the same for the hole project.

How do you change template?

@helenahalldiniths

helenahalldiniths commented Mar 8, 2022

Copy link
Copy Markdown
Contributor

Skärmavbild 2022-03-08 kl  18 56 26

At the top, under "setter template"!

@helenahalldiniths helenahalldiniths self-requested a review March 8, 2022 18:14

@helenahalldiniths helenahalldiniths left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@helenahalldiniths helenahalldiniths merged commit 057d847 into main Mar 8, 2022
@helenahalldiniths helenahalldiniths deleted the crime branch March 8, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Crime

2 participants