Skip to content

style: add prettier#34

Merged
ParthJadhav merged 4 commits intoParthJadhav:masterfrom
benediktms:add-prettier
Jan 12, 2023
Merged

style: add prettier#34
ParthJadhav merged 4 commits intoParthJadhav:masterfrom
benediktms:add-prettier

Conversation

@benediktms
Copy link
Copy Markdown
Contributor

style: add prettier ignore file
style: apply formatting
style: install and apply svelte prettier

Adding as part of conversation from: #3 (comment)

Note: Probably it is also a good idea to add CI workflows to ensure linting is in the correct format

style: add prettier ignore file

style: apply formatting

style: install and apply svelte prettier
Copy link
Copy Markdown
Owner

@ParthJadhav ParthJadhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks so much cleaner now 🙌

Thanks for amazing changes @benediktms !!

@ParthJadhav
Copy link
Copy Markdown
Owner

Oh btw we can add lint command in package.json right?
@benediktms

@benediktms
Copy link
Copy Markdown
Contributor Author

@ParthJadhav Yes, my bad forgot to add that. I'll add one for lint and one for format 👍 speaking of which, at some point it probably also makes sesne sot use eslint for UI linting and clippt lint for rust linting

@ParthJadhav
Copy link
Copy Markdown
Owner

Awesome !! We'll merge that. Thanks for the Contribution @benediktms

@ParthJadhav ParthJadhav merged commit e7ee512 into ParthJadhav:master Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants