fix: set_timezone issue#28
Merged
ParthJadhav merged 1 commit intoParthJadhav:masterfrom Jan 5, 2023
Merged
Conversation
Fix error when offset starts with '+' or '-': ``` thread 'tokio-runtime-worker' panicked at 'called Result::unwrap() on an Err value: "Timezone information not found"', src/util/calculator.rs:26:32 note: run with RUST_BACKTRACE=1 environment variable to display a backtrace ``` For example for `Asia/Almaty` (located in Kazakhstan) `offset_from_utc_date` returns "+6" rather than "GMT+6". This leads to an error beacuse Regex in Smartcalc expects offset with `GMT` in string: https://github.com/erhanbaris/smartcalc/blob/cd39b590aba74e8ca326ba78acea488d0550a3e8/src/json/config.json#L35
Owner
|
Ohh, Good Catch @Ty3uK , Thanks for the Contribution 🚀 I'll merge this and create a minor release. |
Contributor
Author
|
Thanks for immediate response! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix error when offset starts with '+' or '-':
For example for
Asia/Almaty(located in Kazakhstan)offset_from_utc_datereturns "+6" rather than "GMT+6".This leads to an error beacuse Regex in Smartcalc expects offset with
GMTin string:https://github.com/erhanbaris/smartcalc/blob/cd39b590aba74e8ca326ba78acea488d0550a3e8/src/json/config.json#L35