Addition of #![warn(clippy::nursery, clippy::pedantic)].#27
Merged
ParthJadhav merged 3 commits intoParthJadhav:masterfrom Jan 6, 2023
Xithrius:master
Merged
Addition of #![warn(clippy::nursery, clippy::pedantic)].#27ParthJadhav merged 3 commits intoParthJadhav:masterfrom Xithrius:master
#![warn(clippy::nursery, clippy::pedantic)].#27ParthJadhav merged 3 commits intoParthJadhav:masterfrom
Xithrius:master
Conversation
Contributor
Author
|
An example of something that I cannot test is ActivationPolicy, since it's only available on macos. |
Owner
|
Okay @Xithrius , give me a while to test & review it. Thanks a lot for the contribution 🚀 |
ParthJadhav
reviewed
Jan 5, 2023
ParthJadhav
approved these changes
Jan 5, 2023
Owner
ParthJadhav
left a comment
There was a problem hiding this comment.
Just one change about re-adding that line and then we can merge it 🙌
ParthJadhav
reviewed
Jan 6, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helping out with linting, asked here to do this.
I cannot build this on linux, since it relies on the OS being macos. Any testing to see if this actually fully works can only be on that system.