Traffic boost UI label updates and regenerate button removal #3330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (4)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the 📝 WalkthroughWalkthroughThis update standardizes the capitalization of "Smart Link(s)" and related phrases across user-facing strings, error messages, REST API descriptions, and UI components. It also removes the regeneration feature and related UI from the Traffic Boost preview and suggestions workflow, updates several button labels and tab titles for clarity, and makes minor style adjustments to the sidebar. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant TrafficBoostPreview
participant PreviewFooter
participant SuggestionsTab
User->>TrafficBoostPreview: Opens Traffic Boost preview
TrafficBoostPreview->>PreviewFooter: Renders footer (no regenerate button)
User->>SuggestionsTab: Views suggestions
SuggestionsTab-->>User: Shows AddNewLinkButton only (no generate button)
User->>PreviewFooter: Navigates suggestions using prev/next buttons with tooltips
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Contributor
Author
|
@acicovic I think the SonarCloud failure here is ignorable, it's complaining about duplicated code in internationalized strings which is fine to me. |
acicovic
approved these changes
May 16, 2025
Collaborator
acicovic
left a comment
There was a problem hiding this comment.
Thanks for working on this. All changes make sense to me conceptually. We can amend as/if needed in the future.
I'm going to merge this PR immediately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up to #3329 which adds some additional label changes, rearrangement, and simplification of the interface for the
3.19release. Here are the main changes:Any place where we use "Smart Link" in a label, it's been modified to be double capitalized as a proper noun (e.g. "smart links" -> "Smart Links")
The "Generate" left-side button was removed in this commit. Generating new links doesn't typically lead to improved suggestions, and the selected posts are generally very similar to the initial set. This has been removed as an atomic commit to make it easier to re-add if we'd like.
The "Regenerate" right-side button was removed in this commit. The logic here is that the user will likely take over to adjust the link, and clicking "Regenerate" probably doesn't add enough utility to make the button useful enough to add to the UI at this stage. Also done in a single commit to make it easy to revert.
The "Suggestion" dropdown was removed from the footer.
We found three controls to switch between suggestions: The left sidebar of titles, the suggestion dropdown in the toolbar, and the left/right buttons in the toolbar. Because of the redundancy and the ability to move between suggestions more clearly in the sidebar, we removed that footer control.
A handful of label updates to make it more clear what the target post is, and what the source posts are:
This will make it easier to document usage of traffic boost with less overlapping terminology and use standardized language for customers.
Adds tooltips on footer left and right arrows with labels "Next Suggested Source" / "Previous Suggested Source".
Summary by CodeRabbit
New Features
Bug Fixes
Style
Refactor
Documentation
Chores
Tests
Revert