PCH Smart Linking: Show error when API returns empty list of Smart Link suggestions #2654
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In certain scenarios, it is possible for the API to return an empty set of Smart Links as suggestions. When this happens, the Smart Linking review modal does still open, and if there are no existing Smart Links on the content, it will be empty, as reported in #2626.
This PR adds an additional validation after processing the API smart links, and if there are none, it will prevent opening the modal, and will show an error (Snackbar and Notice) instead.
Motivation and context
How has this been tested?
Tested locally, by forcing the API to return an empty response.