lonepair refinement#1266
Merged
Merged
Conversation
This was referenced Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reading in CHARMM psf files, I experienced problems for certain psf files. I included one, generated by CHARMM-GUI, which does not work as expected (loading with
load_psfworks fine, but processing this file or saving it withsave_psfproduces errors):step3_input.zip
I think the problem is, that
_process_lonepair_sectionis only executed, if there is aMOLNTsection, which is sometimes not the case (e.g. when using theopenmmoption in CHARMM-GUI, like for the example provided above)Is there a reason, why
if len(tmp) == len(self.atoms):is used for deciding whether the_process_lonepair_section()function is executed or not?If not, I suggest a check like this: