Skip to content

write PDB conect records for S-S bridges and HETATM#1240

Merged
swails merged 3 commits into
ParmEd:v3.4from
Valdes-Tresanco-MS:pdb_conect_records
May 30, 2022
Merged

write PDB conect records for S-S bridges and HETATM#1240
swails merged 3 commits into
ParmEd:v3.4from
Valdes-Tresanco-MS:pdb_conect_records

Conversation

@Valdes-Tresanco-MS

Copy link
Copy Markdown
Contributor

Sorry, I had to delete the repository and it automatically closed the PR. I include previous code for testing

Here is a well-resolved structure with disulfide bonds. It also has a phosphate ion that serves for heteroatoms
Test code.
Save conect records by default:

import parmed

s = parmed.load_file('3m7q_test.pdb')
s.save('3m7q_parmed.pdb', format='pdb', renumber=False, overwrite=True)

Don't save conect records:

import parmed

s = parmed.load_file('3m7q_test.pdb')
s.save('3m7q_parmed.pdb', format='pdb', renumber=False, overwrite=True, conect=False)

This file contains 3m7q.pdb (Original PDB), 3m7q_test.pdb (PDB without CONECT records) and 3m7q_parmed.pdb (Saved pdb with CONECT records using this PR)
parmed_conect_test.zip

I look forward to your comments
Mario S.

@swails

swails commented Apr 11, 2022

Copy link
Copy Markdown
Contributor

Sorry it took me so long to get to this. It looks great! Can you add a test case and then I'll get it merged.

@Valdes-Tresanco-MS

Copy link
Copy Markdown
Contributor Author

I am not sure if this test is enough. This test fails with PDBs that have the CONECT record for coordination bonds. We can implement it later if necessary

@swails swails merged commit 1742bae into ParmEd:v3.4 May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants