Skip to content

Added 3D-RISM with sander to mdin#1239

Merged
swails merged 4 commits into
ParmEd:v3.4from
Valdes-Tresanco-MS:v3.4
Mar 24, 2022
Merged

Added 3D-RISM with sander to mdin#1239
swails merged 4 commits into
ParmEd:v3.4from
Valdes-Tresanco-MS:v3.4

Conversation

@Valdes-Tresanco-MS

Copy link
Copy Markdown
Contributor

We have added the option to create a mdin for 3D-RISM calculations with sander. While we will be using my fork as we review this PR.
I look forward to your comments

@Valdes-Tresanco-MS

Copy link
Copy Markdown
Contributor Author

I can modify the test without problems, however, it would be good to let me know if it is ok for you.

@swails

swails commented Mar 24, 2022

Copy link
Copy Markdown
Contributor

Definitely good to update the tests. Thanks!

@Valdes-Tresanco-MS

Copy link
Copy Markdown
Contributor Author

We want to implement in gmx_MMPBSA the GBNSR6 model, which has a mdin similar to sander. Should I include it here or create a new PR?

@swails

swails commented Mar 24, 2022

Copy link
Copy Markdown
Contributor

New PR is probably best

@swails

swails commented Mar 24, 2022

Copy link
Copy Markdown
Contributor

let me know when this one is ready and I'll merge it

@Valdes-Tresanco-MS

Copy link
Copy Markdown
Contributor Author

I think that this PR is ready. I'll do a new one for the GBNSR6 model

@swails swails merged commit 555cd28 into ParmEd:v3.4 Mar 24, 2022
@swails

swails commented Mar 24, 2022

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants