Skip to content

Incorrect equality comparison in AtomType equality operator #1359

Description

@murfalo

In the equality operator for AtomType, True is returned if abs(self.charge - other.charge) > TINY. Surely this should return False?

    def __eq__(self, other):
            # ...
            elif abs(self.charge - other.charge) > TINY:
                return True
            #...

(from topologyobjects.py lines 5185-5186)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions