Harmonise Field dimensions order #1812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeckoTheGecko
approved these changes
Jan 7, 2025
Contributor
VeckoTheGecko
left a comment
There was a problem hiding this comment.
Looks good to me, though admittedly I'm not the most familiar with this section of the codebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed om #1646, the order for Field interpolation has been [time, depth, lat, lon] since Parcels v2, . However, under the hood, there are still multiple cases where that order is different.
This PR fixes #1646 by harmonising the order of the dimensions in any Field operation to be
[time, depth, lat, lon]