Implement warning for particles initialised outside time domain #1810
+54
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he fieldset's time bounds This fixes #1694
VeckoTheGecko
requested changes
Jan 7, 2025
Contributor
VeckoTheGecko
left a comment
There was a problem hiding this comment.
LGTM! Just a small refactor request, but otherwise I think its good to go
VeckoTheGecko
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a warning when some particles are set to be released outside the
FieldSet's time boundsIt also adds a new
ParticleSetwarning to the list of Parcels custom warningsThis fixes #1694