Skip to content

Fixing a bug with default ParticleFile outputdt value #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
erikvansebille merged 2 commits into from
Jan 6, 2025
Merged

Fixing a bug with default ParticleFile outputdt value #1808

erikvansebille merged 2 commits into from
Jan 6, 2025

Conversation

@erikvansebille
Copy link
Member

@erikvansebille erikvansebille commented Jan 6, 2025

Removing the outputdt=np.inf default value in ParticleFile.__init__. This fixes #1806

@erikvansebille
Fixing a bug with default ParticleFile outputdt value
a20b321 
Removing the `outputdt=np.inf` default value in `ParticleFile.__init__`. This fixes #1806
@erikvansebille erikvansebille mentioned this pull request Jan 6, 2025
Closed
VeckoTheGecko
VeckoTheGecko approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@VeckoTheGecko VeckoTheGecko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think it was introduced in 23f0bd7 , @erikvansebille do you know what the interpretation of np.inf for outputdt was for? (e.g., not writing the outputs?) Its been a while since that commit, so perhaps just drift

@erikvansebille
Copy link
Member Author

erikvansebille commented Jan 6, 2025

@erikvansebille do you know what the interpretation of np.inf for outputdt was for? (e.g., not writing the outputs?) Its been a while since that commit, so perhaps just drift

The timings of the different callbacks in pset.execute (output, input, repeated, callbackdt etc) are set to np.inf if they are not used, see the line below
https://github.com/OceanParcels/Parcels/blob/07428683c2620030ed626037e2608746f4ffe544/parcels/particleset.py#L1086
and
https://github.com/OceanParcels/Parcels/blob/07428683c2620030ed626037e2608746f4ffe544/parcels/particleset.py#L1152

@erikvansebille erikvansebille merged commit b73b638 into master Jan 6, 2025
16 checks passed
@erikvansebille erikvansebille deleted the fix_particlefile_npinf_bug branch January 6, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VeckoTheGecko VeckoTheGecko VeckoTheGecko approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Parcels development
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Default ParticleFile output frequency results in infinite loop

3 participants

@erikvansebille @VeckoTheGecko