Adding explicit explanation how to add tracers in FieldSet.from_nemo() #1702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Spelling fix
Contributor
VeckoTheGecko
left a comment
There was a problem hiding this comment.
Are there any usecases then for providing T-points to the Nemo constructor?
Do you think we should also add additional validation to the from_nemo function? Maybe if there's no usecase for T-points, we can warn if they provide >2 unique dimensions for grids.
Member
Author
Well, users may want to add wind or stokes drift from other models, that would then be on a different grid. So I don't think we can enforce only 1 Grid when the velocities are from_nemo |
VeckoTheGecko
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1700