Combine workflow files, add codecov token #1667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were getting rate limited, so unit testing results weren't being uploaded
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files@@ Coverage Diff @@
## master #1667 +/- ##
===========================================
+ Coverage 64.50% 86.40% +21.89%
===========================================
Files 48 67 +19
Lines 7610 11746 +4136
===========================================
+ Hits 4909 10149 +5240
+ Misses 2701 1597 -1104
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
Author
|
Yay! Bot integration looks to be working. Turns out this PR improves our coverage by 20% (from 64.50% to 86.4%) now the coverage isn't just looking at integration tests 😄 |
8399737 to
593cbdc
Compare
erikvansebille
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in title. I just realised we don't have any coverage on unit tests in CodeCov since we were being rate limited before. Specifying a token should help with this.