Fix bug in JIT when interpolation overrides error of previous interpolation #1645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in JIT when an interpolation call overrides the error thrown before by another interpolation.
This could for example happen when a 3D interpolation throws an OutofSurface error, but a subsequent call to a 2D interpolation returns SUCCESS. Since the whole kernel will then return the last particle.state, the error is not captured
In this PR, the particle.state is always kept at the maximum error code. Since Errors are always higher than success (see this part of the kernel loop tutorial, errors thrown by any interpolation are propagated.