Skip to content

Revert from dirHtml builder, update version default, clarify support for fieldset=None in ParticleSet API, doc copy edits #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
VeckoTheGecko merged 15 commits into from
Aug 9, 2024
Merged

Revert from dirHtml builder, update version default, clarify support for fieldset=None in ParticleSet API, doc copy edits #1644

VeckoTheGecko merged 15 commits into from
Aug 9, 2024
+66 −67

Conversation

@VeckoTheGecko
Copy link
Contributor

@VeckoTheGecko VeckoTheGecko commented Aug 8, 2024 •
edited
Loading

Code

  • Officially remove support for fieldset=None in ParticleSet API
  • Update version retrieval to avoid git call by default
  • pset.execute() notes and clean up some variable instantiation
    • Will delay a refactoring until I have a better overview of the codebase

Docs

  • Revert from dirHtml builder to original builder
    • I was encountering difficulty with the version switcher was not linking the pages properly between the new and old documentation versions, leading to people encountering 404s. I thought this could be accounted for fully using redirects, but I don't think so.
  • Add version warning on tutorial homepage
  • Copy edits to parcels_tutorial.ipynb

@VeckoTheGecko VeckoTheGecko reopened this Aug 8, 2024
@VeckoTheGecko
Copy link
Contributor Author

VeckoTheGecko commented Aug 8, 2024

Looks like making the output less verbose is more complicated than I thought 😂. The problem I think is the progress bar in .execute(). Leaving for now

erikvansebille
erikvansebille reviewed Aug 8, 2024
View reviewed changes
erikvansebille
erikvansebille reviewed Aug 9, 2024
View reviewed changes
@VeckoTheGecko @erikvansebille
Update parcels/particleset.py
a162f6b 
Co-authored-by: Erik van Sebille <e.vansebille@uu.nl>
@VeckoTheGecko VeckoTheGecko merged commit f098b4d into master Aug 9, 2024
@VeckoTheGecko VeckoTheGecko deleted the v/small-changes branch August 9, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erikvansebille erikvansebille erikvansebille approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Parcels development
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@VeckoTheGecko @erikvansebille