-
Notifications
You must be signed in to change notification settings - Fork 168
PyPi release updates #1574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyPi release updates #1574
Conversation
|
Thanks for adding this workflow, @andrew-s28! However, it doesn't seem to be triggered by Actions. Not sure why, I already renamed it from pypi-release.yaml to pypi.release.yml. Do you know what I should do to automatically have it checked by Actions? |
How you tried? |
Just to check if it works
|
Thanks @VascoSch92, I didn't realise that the Action will only be triggered upon release. Before merging, I would want to check if it indeed passes all tests, as intended, though. So I now (temporarily?) added a check for every pull-request. But the |
Because the job I think the beast way to test it is to delete |
|
Nice :-) |
This adds dependencies to the pyproject.toml files (except for the c compiler dependency, which cannot be installed from pip) and includes a basic test in the pypi-release workflow that uses conda to install a c compiler then pip installs the Parcels release from PyPi and runs the example_peninsula.py file. This is meant to mimic the workflow in the conda recipe and should hopefully simplify efforts to keep pyproject.toml up to date.
The updated workflow was tested on my personal test.pypi.org release.
Closes #1550