unpin zarr version upper bound #1567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
reviewed
May 18, 2024
Contributor
jakirkham
left a comment
There was a problem hiding this comment.
Thanks James! 🙏
Had a minor suggestion below. Though leave it to you as to whether or not to include it
Co-authored-by: jakirkham <jakirkham@gmail.com>
Contributor
Author
|
@jakirkham Thanks very much for the suggestion! It's been incorporated 👍 |
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #1564 a simple change of the environment.yml back to
zarr>=2.11.0.Still seeing a couple of failed parameterized tests for
test_mpi_runbut this may be a local issue.Thought I'd just put this PR up here for discussion of those tests or whatever else we may want to do here. Feel free to disregard if not helpful.