Retiring AoS support #1423
Merged
Retiring AoS support #1423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Also fixing pydocstyle errors
and also fixing flake8 error
for more information, see https://pre-commit.ci
As they are outdated now (and not used anywhere)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removed support for the Array-of-Structures (AoS) data structure in Parcels. While it was the original data structure in Parcels, it has not been the default since #678 in March 2020, it is not advertised in any of the tutorials, and it is probably used by very few (if any) users.
Now that Christian Kehl's article in GMD has shown that there are no use cases where AoS is faster than the default Structure-of-Arrays (SoA) data structure, there is no real reason to keep it.
Maintaining two data structures significantly adds to the coding burden, both for bug-fixes and (especially) for new functions. It does therefore have a big cost.
This PR therefore retires the AoS data structure.