Improve the check if Shared network adapter is connected#96
Merged
legal90 merged 1 commit intoParallels:masterfrom Oct 13, 2020
Merged
Improve the check if Shared network adapter is connected#96legal90 merged 1 commit intoParallels:masterfrom
legal90 merged 1 commit intoParallels:masterfrom
Conversation
It fixes the compatibility with Parallels Desktop 16 and macOS 11, Parallels#93 Instead of matching the output of "prlsrvctl net info Shared" with "Bound To", we parse the adapter's IP and look if there is an interface with this IP assigned on the host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #93
This PR fixes the compatibility issue with Parallels Desktop 16 and macOS 11 Big Sur.
Instead of looking for
"Bound To"in the output ofprlsrvctl net info Shared, now we will parse the adapter's IP and look if there is a network interface with this IP assigned on the host.