Switch the dependency management tool "godep" -> "dep"#79
Merged
legal90 merged 6 commits intoParallels:masterfrom Dec 27, 2018
Merged
Switch the dependency management tool "godep" -> "dep"#79legal90 merged 6 commits intoParallels:masterfrom
legal90 merged 6 commits intoParallels:masterfrom
Conversation
Do not require godep. Refer to dep docs for further info.
Switched to the "dep" tool
5f0509c to
47f6649
Compare
romankulikov
approved these changes
Dec 27, 2018
Collaborator
romankulikov
left a comment
There was a problem hiding this comment.
Frankly it's impossible to review such huge changes. So I approve it just because the change is sane and reasonable.
Collaborator
Author
Yeah, I understand :( . The content of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools/godepwas deprecated in favor ofgolang/dep.It removes a lot of hassle with managing dependencies for Go projects. So, I decided to switch to it in this project.
Now direct dependencies are declared in
Gopkg.tomland locked inGopkg.lock.How to update the dependency version:
Gopkg.tomldep ensureGopkg.toml,Gopkg.lockandvendor/*We still have the content of
vendor/dir in the git index for easier start -deptool is not required to build a project.We can gitignore the
vendor/content in the future if we want.In the scope of this PR I have also updated some dependencies:
github.com/docker/machine:0.12.2->0.16.0github.com/hashicorp/go-version:03c5bf6->1.0.0github.com/urfave/cli:1.18.0->1.20.0and their transitive dependencies
Acceptance test are passed.