[Enhancement] Add support for discriminators#174
Merged
Conversation
|
Size Change: +73.2 kB (+2%) Total Size: 3.51 MB
ℹ️ View Unchanged
|
|
Visit the preview URL for this PR (updated for commit 10268b4): https://docusaurus-openapi-36b86--pr174-3t1vn2no.web.app (expires Sat, 27 Aug 2022 18:15:50 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
blindaa121
reviewed
Jul 26, 2022
packages/docusaurus-plugin-openapi-docs/src/openapi/utils/loadAndResolveSpec.ts
Outdated
Show resolved
Hide resolved
Member
Author
|
I reordered the description and qualifier and removed the margin-top for consistency.
I also took one more pass at ensuring there will be nested support for discriminators. Since it's basically handled in |
…ocusaurus-openapi-docs into handle-discriminators
Member
Author
|
Initially, we were only handling discriminators that mapped directly to a property at the same level as the discriminator. The recent push adds support for discriminators that map to a property inside the discriminator mapping schema itself. Example 1: Screen.Recording.2022-07-28.at.7.32.28.AM.movExample 2: Screen.Recording.2022-07-28.at.7.33.39.AM.mov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses FR #156
Motivation and Context
We should do our best to support all polymorphism types, including discriminators.
How Has This Been Tested?
See deploy preview Petstore API for examples.
Screenshots (if appropriate)