fix: handle undefined when outputDir doesn't contain docPath#1271
Merged
fix: handle undefined when outputDir doesn't contain docPath#1271
Conversation
Fixes TypeError when using multiple docs plugin instances with mismatched path configurations. The code now safely handles cases where outputDir.split(docPath) returns undefined. Fixes both occurrences: - sidebars/index.ts: basePath calculation - index.ts: infoBasePath calculation Closes #1224 Co-authored-by: sserrata <sserrata@users.noreply.github.com>
|
Size Change: 0 B Total Size: 2.18 MB ℹ️ View Unchanged
|
|
Visit the preview URL for this PR (updated for commit 0f12e7d): https://docusaurus-openapi-36b86--pr1271-4rw6grz8.web.app (expires Sun, 18 Jan 2026 21:45:18 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: bf293780ee827f578864d92193b8c2866acd459f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes TypeError when using multiple docs plugin instances with mismatched path configurations. The code now safely handles cases where outputDir.split(docPath) returns undefined.
Fixes both occurrences:
Closes #1224
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate)
Types of changes
Checklist