fix: the current type module path confusing typescript tsc#1216
Closed
tawago wants to merge 1 commit intoPaloAltoNetworks:mainfrom
tawago:1015-fix-type-import-error
Closed
fix: the current type module path confusing typescript tsc#1216tawago wants to merge 1 commit intoPaloAltoNetworks:mainfrom tawago:1015-fix-type-import-error
tsc#1216tawago wants to merge 1 commit intoPaloAltoNetworks:mainfrom
tawago:1015-fix-type-import-error
Conversation
tsc
tsctsc
Member
Author
Author
|
closing the PR. see #1216 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves:
Motivation and Context
The type error:
is really confusing because it seems like an official
@docusauruspackage in https://github.com/facebook/docusaurus/tree/main/packages but it's not. It gives an extra hurdle for typescript to resolve types.NOTE: This PR does not address:
as
"moduleResolution": "node"can solve it.How Has This Been Tested?
Successfully ran commands to build the project and serve the demo
Types of changes
Bug fix / cleanup
A simple path update
packages/docusaurus-plugin-openapi-docs/src/types.tsDirectly export from the type file
packages/docusaurus-plugin-openapi-docs/src/plugin-content-docs-types.d.tsChecklist