[Bug Fix] Properly handle empty Discriminator Tab children#1108
Merged
blindaa121 merged 1 commit intomainfrom Mar 11, 2025
Merged
[Bug Fix] Properly handle empty Discriminator Tab children#1108blindaa121 merged 1 commit intomainfrom
blindaa121 merged 1 commit intomainfrom
Conversation
|
Size Change: +11.1 kB (+0.55%) Total Size: 2.02 MB
ℹ️ View Unchanged
|
|
Visit the preview URL for this PR (updated for commit 5a71263): https://docusaurus-openapi-36b86--pr1108-at71721z.web.app (expires Thu, 10 Apr 2025 18:13:15 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: bf293780ee827f578864d92193b8c2866acd459f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a regression bug introduced in #1099 which caused Discriminator Tabs to not render. The bug was caused by an invalid check against empty Discriminator
propschildren.See #1106 for context.
How Has This Been Tested?
Tested with example spec in original issue and navigating to
get-series-list, as well as ensuring that Discriminator tabs are still rendering as expected under our available Discriminator test examples.Screenshots (if appropriate)
Types of changes
Checklist