Skip to content

Unable to build due to missing url and buffer dependencies #1088

@sserrata

Description

@sserrata

Describe the bug

Unable to successfully build due to missing modules:

× Module not found: Can't resolve 'url' in '/Users/sserrata/projects/panw/pan.dev/node_modules/postman-code-generators/codegens/csharp-restsharp/lib'
   ╭─[7:12]
 5 │   sanitizeOptions = require('./util').sanitizeOptions,
 6 │   addFormParam = require('./util').addFormParam,
 7 │   { URL } = require('url'),
   ·             ──────────────
 8 │   self;
 9 │ 
   ╰────

--------------------------

× Module not found: Can't resolve 'buffer' in '/Users/sserrata/projects/panw/pan.dev/node_modules/safe-buffer'
   ╭─[3:13]
 1 │ /*! safe-buffer. MIT License. Feross Aboukhadijeh <https://feross.org/opensource> */
 2 │ /* eslint-disable node/no-deprecated-api */
 3 │ var buffer = require('buffer')
   ·              ─────────────────
 4 │ var Buffer = buffer.Buffer
 5 │ 
   ╰────

--------------------------

× Module not found: Can't resolve 'buffer' in '/Users/sserrata/projects/panw/pan.dev/node_modules/safer-buffer'
   ╭─[5:13]
 3 │ 'use strict'
 4 │ 
 5 │ var buffer = require('buffer')
   ·              ─────────────────
 6 │ var Buffer = buffer.Buffer
 7 │ 
   ╰────

This issue was introduced following the removal of node-polyfill-webpack-plugin from package dependencies. See #1081

Expected behavior

The plugin and theme should include all required dependencies.

Current behavior

If url and/or buffer are not installed builds will fail.

Possible solution

Include both url and buffer in theme dependencies, either as explicit or peer dependencies.

Steps to reproduce

  1. Install latest canary release (0.0.0-979)
  2. Attempt a developer or production build

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions