Skip to content

feat: Account management API#878

Merged
santhosh-challa merged 6 commits into
masterfrom
feat/account-mgmt
Mar 1, 2023
Merged

feat: Account management API#878
santhosh-challa merged 6 commits into
masterfrom
feat/account-mgmt

Conversation

@dheerajkholia-paladin

@dheerajkholia-paladin dheerajkholia-paladin commented Feb 24, 2023

Copy link
Copy Markdown
Contributor

Description

  • Account management APIs
  • Collector changes for account managemnet

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List
any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Chore (no code changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My commit message/PR follows the contribution guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Other information:

List any documentation updates that are needed for the Wiki

- Account management APIs
- Collector changes for account managemnet
//find and delete cred file for account
String fileName="gcp-credential-"+projectId+".json";
String credFilePath = credentialFilePath + File.separator + fileName;
File file=new File(credFilePath);

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression

This path depends on a [user-provided value](1).
@rnithinpaladin rnithinpaladin force-pushed the feat/account-mgmt branch 14 times, most recently from fe1bf1f to fbbbcb9 Compare February 28, 2023 07:46
@rnithinpaladin rnithinpaladin force-pushed the feat/account-mgmt branch 8 times, most recently from 9b5f7a7 to 8d586ee Compare March 1, 2023 05:14
@rnithinpaladin rnithinpaladin force-pushed the feat/account-mgmt branch 10 times, most recently from ea7ddf3 to 6925a41 Compare March 1, 2023 09:02
@sonarqubecloud

sonarqubecloud Bot commented Mar 1, 2023

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 27 Code Smells

0.0% 0.0% Coverage
10.8% 10.8% Duplication

@santhosh-challa

santhosh-challa commented Mar 1, 2023

Copy link
Copy Markdown
Contributor

@dheerajkholia-paladin let's resolve sonar issues in the next prs.

@santhosh-challa santhosh-challa merged commit b3ebcde into master Mar 1, 2023
@santhosh-challa santhosh-challa deleted the feat/account-mgmt branch March 1, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants