Skip to content

feat: added client side filters for policy-knowledgebase, admin/polic…#846

Merged
sidharthjain-zemoso merged 4 commits into
masterfrom
feat/client-side-filter
Mar 13, 2023
Merged

feat: added client side filters for policy-knowledgebase, admin/polic…#846
sidharthjain-zemoso merged 4 commits into
masterfrom
feat/client-side-filter

Conversation

@sidharthjain-zemoso

@sidharthjain-zemoso sidharthjain-zemoso commented Feb 17, 2023

Copy link
Copy Markdown
Contributor

Description

  1. Added client side filters for policy-knowledgebase, admin/policy and compliance overview list in dashboard.
  2. Removed server side search and added client side search in above screens until we have server side filter.
  3. Made admin/policies to load complete data on load and removed onscroll data load.

Fixes # (issue)

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The commit message/PR follows our guidelines

@ranadheer-b ranadheer-b left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sidharthjain-zemoso sidharthjain-zemoso merged commit 75f954e into master Mar 13, 2023
@sidharthjain-zemoso sidharthjain-zemoso deleted the feat/client-side-filter branch March 13, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants