Skip to content

fix: angular tests#798

Merged
santhosh-challa merged 12 commits into
PaladinCloud:masterfrom
astra1:fix/test
Feb 20, 2023
Merged

fix: angular tests#798
santhosh-challa merged 12 commits into
PaladinCloud:masterfrom
astra1:fix/test

Conversation

@astra1

@astra1 astra1 commented Feb 9, 2023

Copy link
Copy Markdown
Contributor

Description

Updated angular tests (mostly providers imports) to prepare webapp for unit testing

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The commit message/PR follows our guidelines

Other information:

@plyubich plyubich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ranadheer-b ranadheer-b left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@santhosh-challa santhosh-challa merged commit 1bb9adc into PaladinCloud:master Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants