feat : Enable automatic restart for vm instances#772
Merged
santhosh-challa merged 11 commits intoFeb 8, 2023
Conversation
# Conflicts: # installer/resources/lambda_rule_engine/files/rule_engine_cloudwatch_gcp_rules.json # installer/resources/pacbot_app/files/DB_Policy.sql # jobs/pacman-awsrules/src/main/java/com/tmobile/cloud/constants/PacmanRuleConstants.java
# Conflicts: # installer/resources/lambda_rule_engine/files/rule_engine_cloudwatch_gcp_rules.json # installer/resources/pacbot_app/files/DB_Policy.sql
# Conflicts: # installer/resources/pacbot_app/files/DB_Policy.sql
| (disk.getAsJsonObject().get(PacmanRuleConstants.TYPE).getAsString().equals(PacmanRuleConstants.PERSISTENT)) && ( | ||
| (disk.getAsJsonObject().get(PacmanRuleConstants.AUTO_DELETE) == null ) || (disk.getAsJsonObject().get(PacmanRuleConstants.AUTO_DELETE) != null && | ||
| disk.getAsJsonObject().get(PacmanRuleConstants.AUTO_DELETE).getAsBoolean()))){ | ||
| validationResult = false; |
Contributor
There was a problem hiding this comment.
For better readability can we refactor disk.getAsJsonObject().get(PacmanRuleConstants.TYPE)
and disk.getAsJsonObject().get(PacmanRuleConstants.AUTO_DELETE) as variables
AishwaryaKulkarni97
approved these changes
Feb 7, 2023
dheerajkholia-paladin
approved these changes
Feb 7, 2023
# Conflicts: # installer/resources/lambda_rule_engine/files/rule_engine_cloudwatch_aws_rules.json # installer/resources/lambda_rule_engine/files/rule_engine_cloudwatch_gcp_rules.json # installer/resources/pacbot_app/files/DB_Policy.sql
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To improve reliability, ensure that Google Cloud Compute Engine service restarts automatically your virtual machine instances when they are terminated due to non-user initiated reasons such as maintenance events, hardware, and software failures.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Jobexector was run to generate data file. The file was uploaded in the s3 batch and shipper was run to fetch the data in the elastic search. Moreover, all three rules written were tested and also, unit test have been created and run against each rule.
Checklist:
Other information: