Skip to content

chore:removed vulenrablity issue from webapp image#1967

Open
rnithinpaladin wants to merge 1 commit into
masterfrom
chore/removed_vulenrablity_for_webapp_image
Open

chore:removed vulenrablity issue from webapp image#1967
rnithinpaladin wants to merge 1 commit into
masterfrom
chore/removed_vulenrablity_for_webapp_image

Conversation

@rnithinpaladin

Copy link
Copy Markdown
Contributor

Description

Removed vulnerability issue created by web app docker image

Screenshot from 2023-12-18 17-57-47

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Chore (no code changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My commit message/PR follows the contribution guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Other information:

List any documentation updates that are needed for the Wiki

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

pip3 install --upgrade pip setuptools

# Install AWS CLI using pip
RUN pip3 install awscli

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the web app container need access to AWS cli?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can that jar be copied to docker beforehand like you do with Nginx config below?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Webapp dist.zip folder is different for each Tenant's.
Configuration.ts file will vary for each Tenant's

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to move values from Tenant configuration value from configuration.ts to environmental variable

pip3 install --upgrade pip setuptools

# Install AWS CLI using pip
RUN pip3 install awscli

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can that jar be copied to docker beforehand like you do with Nginx config below?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants