fix:[CORE-1352]Remove ops alert for access denied#1562
Conversation
| buckets.add(new BucketVH(bucket, "", versionconfig, tags, null, hasWebSiteConfiguration, bucketLoggingConfiguration, null)); | ||
| } else { | ||
| log.info("Exception fetching S3 Bucket", e); | ||
| ErrorManageUtil.uploadError(accountId, "", "s3", e.getMessage()); |
There was a problem hiding this comment.
we need to review this piece. @AishwaryaKulkarni97 @raviteja-mandala
| log.info("Omit exception :{}",errorVH.getException()); | ||
| errorVHList.remove(errorVH); | ||
| } | ||
| if(errorVH.getType().equals("kms")&&errorVH.getException().contains("AccessDeniedException")) |
There was a problem hiding this comment.
3 blocks can be merged to one.
errorVH.getException().contains("AccessDeniedException") && Arrays.asList("kms","s3","check").contains(errorVH.getType())
|
Kudos, SonarCloud Quality Gate passed!
|
|
@AishwaryaKulkarni97 @santhosh-challa Now this PR is closed, and is still labeled as "Do not merge". Should we worried about it? |
| //if permission is denied to get list of secrets, then do not raise any violation | ||
| vaultVH.setSecretExpirationDate(new HashSet<>()); | ||
| log.info(e.getMessage()); | ||
| log.error(e.getMessage()); |
There was a problem hiding this comment.
@santhosh-challa I dont think this should be an error since we are handling a valid scenario. WE should log this as a simple log like along "skipping collecting asset type x. Permissions Denied" and create a record in Notifications with source = Paladin Cloud type = Permission
Description
Ops alert should not be generated for:
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration
Checklist:
Other information:
List any documentation updates that are needed for the Wiki