feat:[CUS-170] Added ec2 launch template.#1540
Merged
Merged
Conversation
1310389 to
7ec4920
Compare
7ec4920 to
a06977f
Compare
arunpaladin
approved these changes
Sep 1, 2023
arunpaladin
left a comment
Collaborator
There was a problem hiding this comment.
Good.
Can u please updated the unit test for modified polices.
| } | ||
| } | ||
| }catch(Exception e){ | ||
| log.warn(expPrefix+ region.getName()+InventoryConstants.ERROR_CAUSE +e.getMessage()+"\"}"); |
Contributor
There was a problem hiding this comment.
it should be log.error
Contributor
Author
There was a problem hiding this comment.
For every collector in aws we are use log.warn only
Contributor
Author
Done |
|
Kudos, SonarCloud Quality Gate passed!
|
santhosh-challa
approved these changes
Sep 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List
any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration
Checklist:
Other information:
List any documentation updates that are needed for the Wiki