Skip to content

fix:[CORE-1209] fix for data dog reported issue for rule - AWS_IAM_Us…#1490

Merged
santhosh-challa merged 1 commit into
masterfrom
fix/iamuserfulladminprivilege-rule-fix
Aug 10, 2023
Merged

fix:[CORE-1209] fix for data dog reported issue for rule - AWS_IAM_Us…#1490
santhosh-challa merged 1 commit into
masterfrom
fix/iamuserfulladminprivilege-rule-fix

Conversation

@raviteja-mandala

Copy link
Copy Markdown
Contributor

…er_Full_Admin_Privilege_version-1_Admin_Privilege_iamuser

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List
any dependencies that are required for this change.

Fixes # (issue)

  1. Fix for data dog reported issue for rule - AWS_IAM_User_Full_Admin_Privilege_version-1_Admin_Privilege_iamuser.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Chore (no code changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My commit message/PR follows the contribution guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Other information:

List any documentation updates that are needed for the Wiki

…er_Full_Admin_Privilege_version-1_Admin_Privilege_iamuser
@raviteja-mandala raviteja-mandala force-pushed the fix/iamuserfulladminprivilege-rule-fix branch from 39f9dec to adc9f00 Compare August 10, 2023 06:46

mustTermsFilter.put(convertAttributetoKeyword(PacmanRuleConstants.GROUP_NAME), groupList);
mustFilter.put(PacmanSdkConstants.ACCOUNT_ID, accountId);
mustFilter.put(LATEST,"true");

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove "". it is of boolean type in ES


mustTermsFilter.put(convertAttributetoKeyword(PacmanRuleConstants.ES_ATTRIBUTE_POLICYNAME), iamPolicyNameSet);
mustFilter.put(PacmanSdkConstants.ACCOUNT_ID,accountId);
mustFilter.put(LATEST,"true");

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove ""

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
3.4% 3.4% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@santhosh-challa santhosh-challa merged commit 3f42e2e into master Aug 10, 2023
@santhosh-challa santhosh-challa deleted the fix/iamuserfulladminprivilege-rule-fix branch August 10, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants