Improves logging of error responses.#9
Merged
ChezCrawford merged 1 commit intomasterfrom Nov 10, 2020
Merged
Conversation
0bf6caf to
6bfbd90
Compare
dobs
approved these changes
Nov 3, 2020
ChezCrawford
commented
Nov 3, 2020
| } else if !r.IsRetryable(resp, err) { | ||
| if err == nil { | ||
| err = ErrAPIError | ||
| if resp != nil { |
Author
There was a problem hiding this comment.
Adheres to the RoundTripper interface by returning err == nil in the event an HTTP response is received.
The calling code in pkg/eventsapi/eventsapi.go only attempts to parse the response body if no err is returned so this helps there as well.
e4d2595 to
8a5dfcd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP requests that return "error" status codes should now be properly logged.