Skip to content

Move retries to eventsapi package.#6

Merged
dobs merged 2 commits intomasterfrom
move-retries-to-eventsapi
Apr 24, 2020
Merged

Move retries to eventsapi package.#6
dobs merged 2 commits intomasterfrom
move-retries-to-eventsapi

Conversation

@dobs
Copy link
Copy Markdown
Contributor

@dobs dobs commented Apr 24, 2020

This yanks retry handling out of eventqueue's processor and moves it closer to where we're actually interacting with the API.

In doing so it keeps best practices around retries closer to the API client itself, fully (or at least hopefully-fully) abstracts those details for package users, and lets us drop some of the retry-related info that we were previously exposing from eventsapi to support retries elsewhere.

dobs added 2 commits April 18, 2020 21:05
This is closer to what we probably should have had from the start:
Invisibly handling retries as middleware (a `RoundTripper`) rather than
requiring that processors handle it.

This also meant moving concepts like `retryable` and corresponding
`success` to the `RetryTransport` rather than making it part of
`eventsapi` response handling.

A next step could be to further pull this out into its own service or
package, but for now it's at least fairly self-contained within
`eventsapi`.
@dobs dobs merged commit 459a1d5 into master Apr 24, 2020
@dobs dobs deleted the move-retries-to-eventsapi branch April 24, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant