Conversation
This is closer to what we probably should have had from the start: Invisibly handling retries as middleware (a `RoundTripper`) rather than requiring that processors handle it. This also meant moving concepts like `retryable` and corresponding `success` to the `RetryTransport` rather than making it part of `eventsapi` response handling. A next step could be to further pull this out into its own service or package, but for now it's at least fairly self-contained within `eventsapi`.
…as successful or retryable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This yanks retry handling out of
eventqueue's processor and moves it closer to where we're actually interacting with the API.In doing so it keeps best practices around retries closer to the API client itself, fully (or at least hopefully-fully) abstracts those details for package users, and lets us drop some of the retry-related info that we were previously exposing from
eventsapito support retries elsewhere.