Merged
Conversation
31963b4 to
9c12438
Compare
ChezCrawford
suggested changes
Jul 12, 2021
ChezCrawford
left a comment
There was a problem hiding this comment.
Have you tested out whether you can set region: eu in the config.yaml and have the events sent to the correct place? I think that is the primary use case here and it does not seem to be working properly for me.
| @@ -0,0 +1,10 @@ | |||
| package cmdutil | |||
|
|
|||
| func ValidateEnumField(inputVal string, allowedValues []string, err error) error { | |||
Contributor
Author
Interesting, it works for me if I do these steps:
When the server starts up I see this in the server logs: Are you doing anything differently? Would love to test you method out to see what's going wrong. UPDATE: pushed a fix for this here -> 6a02985 |
ChezCrawford
approved these changes
Jul 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
regionflag to theservercommand that can be eitherusoreuand determines which PagerDuty region the daemon should talk to. If the flag is not provided it defaults tous.