[Improvement] Remove redundant codes in dataset.py #1584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete redundant lines.
wuyefeilin
reviewed
Dec 2, 2021
| self.file_list = list() | ||
| mode = mode.lower() | ||
| self.mode = mode | ||
| self.mode = mode.lower() |
Collaborator
There was a problem hiding this comment.
如果删除mode=mode.lower(), 后面使用到的mode也需要同步改成self.mode
Contributor
Author
There was a problem hiding this comment.
这是在Web端查看时发现而直接修改的，疏忽了......
另外，关于该文件我有两个注意点：
- 将
{train_path, val_path, test_path}合并成file_path是否会更加方便； - 对于
mode='test'，在之后的 API 中（如evaluate/predict）均没有使用。
Collaborator
There was a problem hiding this comment.
非常感谢您的反馈，关于path的问题我们会进行评估哈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete redundant lines.