Skip to content

Conversation

@wjm202
Copy link
Contributor

@wjm202 wjm202 commented Jun 8, 2023

No description provided.

@paddle-bot
Copy link

paddle-bot bot commented Jun 8, 2023

Thanks for your contribution!

nemonameless
nemonameless previously approved these changes Jun 8, 2023
nemonameless
nemonameless previously approved these changes Jun 9, 2023


@register_op
class BatchRandomResize_semi_detr(BaseOperator):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个命名不友好,另外是否和BatchRandomResize合并,或者BatchRandomResizeForSSOD,不使用下划线

logger = setup_logger('ppdet.engine')

__all__ = ['Trainer_DenseTeacher', 'Trainer_ARSL']
__all__ = ['Trainer_DenseTeacher', 'Trainer_ARSL', 'Trainer_Semi_detr']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里改名为Semi_RTDETR更合理,Semi-DETR是另一篇工作

losses = self.student.detr_head(out_transformer, body_feats,
student_unsup)

losses['loss_class'] *= 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的操作是否必要?可以有更简洁的实现方式还有增加注释

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,已经全部修改了

@nemonameless nemonameless merged commit 3e5bf8a into PaddlePaddle:develop Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants