-
Notifications
You must be signed in to change notification settings - Fork 5.9k
【FlexCheckpoint】Add AOA transpose and cast #74814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
你的PR提交成功,感谢你对开源项目的贡献! |
|
/re-run all-failed |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #74814 +/- ##
==========================================
Coverage ? 96.59%
==========================================
Files ? 2
Lines ? 88
Branches ? 0
==========================================
Hits ? 85
Misses ? 3
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/re-run coverage |
|
/re-run all-failed |
|
/re-run all-failed |
|
LGTM |
|
|
||
| def transpose(self, tensor: TensorDesc) -> TensorDesc: | ||
| raise NotImplementedError | ||
| def transpose(self, tensor: TensorDesc, transpose: str) -> TensorDesc: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里 transpose 函数里用 transpose 参数感觉很容易混淆,后续是否可以调整下命名?
| raise NotImplementedError | ||
| def transpose(self, tensor: TensorDesc, transpose: str) -> TensorDesc: | ||
| slices = [] | ||
| tensor_shape = transpose_list(tensor.shape, eval(transpose)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
下个 PR eval 修改为 ast.literal_eval
From00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Category
User Experience
PR Types
New features
Description
AOAEngine 增添 transpose 和 cast 原语实现,并修复 bug。