Skip to content

Conversation

@NKNaN
Copy link
Contributor

@NKNaN NKNaN commented Aug 21, 2025

PR Category

User Experience

PR Types

New features

Description

AOAEngine 增添 transpose 和 cast 原语实现,并修复 bug。

@paddle-bot
Copy link

paddle-bot bot commented Aug 21, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Aug 21, 2025
@NKNaN
Copy link
Contributor Author

NKNaN commented Aug 22, 2025

/re-run all-failed

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2025

Codecov Report

❌ Patch coverage is 96.59091% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@8b5c009). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ddle/distributed/flex_checkpoint/aoa/aoa_engine.py 96.42% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #74814   +/-   ##
==========================================
  Coverage           ?   96.59%           
==========================================
  Files              ?        2           
  Lines              ?       88           
  Branches           ?        0           
==========================================
  Hits               ?       85           
  Misses             ?        3           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NKNaN
Copy link
Contributor Author

NKNaN commented Aug 22, 2025

/re-run coverage

@NKNaN NKNaN changed the title 【FlexCheckpoint】Add AOA transpose 【FlexCheckpoint】Add AOA transpose and cast Aug 26, 2025
@AndSonder
Copy link
Contributor

/re-run all-failed

@NKNaN
Copy link
Contributor Author

NKNaN commented Aug 27, 2025

/re-run all-failed

@xingmingyyj
Copy link
Contributor

LGTM


def transpose(self, tensor: TensorDesc) -> TensorDesc:
raise NotImplementedError
def transpose(self, tensor: TensorDesc, transpose: str) -> TensorDesc:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里 transpose 函数里用 transpose 参数感觉很容易混淆,后续是否可以调整下命名?

raise NotImplementedError
def transpose(self, tensor: TensorDesc, transpose: str) -> TensorDesc:
slices = []
tensor_shape = transpose_list(tensor.shape, eval(transpose))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

下个 PR eval 修改为 ast.literal_eval

Copy link
Contributor

@From00 From00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@From00 From00 merged commit 51a0f1d into PaddlePaddle:develop Aug 27, 2025
70 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants