Message versioning and ROS 2 message translation#3465
Message versioning and ROS 2 message translation#3465hamishwillee merged 16 commits intoPX4:mainfrom
Conversation
a0c25d8 to
ac87603
Compare
ac87603 to
66ced5a
Compare
41873cf to
825115e
Compare
3c869fb to
2a3af80
Compare
2a3af80 to
22a480e
Compare
|
@hamishwillee I think the PR is in a review ready state. I left a few |
22a480e to
8d080d2
Compare
ba8dd9a to
cd7e2cb
Compare
|
@hamishwillee The implementation PR is ready to merge in my opinion, it's all good from a user workflow perspective when I tested it. There hasn't been much activity from the community but FWIW I've just given my approval, I think we can expect it to get merged soon |
|
Thanks for the update @GuillaumeLaine - really appreciate your attention to detail. I am happy for this to go in. There are just two outstanding suggestions for your consideration: |
|
@GuillaumeLaine I don't have any other comments. Looks good to go in when the code PR goes in. |
|
@hamishwillee Awesome thanks! Really appreciate you taking the time to refine things until they're right 🙌🏻 |
4df50b5 to
1c4af85
Compare
|
Once this PR is in, we need a blog post on px4.io, who would like to co-author with me? |
|
No flaws found |
|
@GuillaumeLaine I missed that the associated PR merged! Yee har! I made a few more changes. Updated this first section to make it clear that that the file might not go into the top level.
Did restructure to move the topics such as versioning above the stuff around plotting and publishing - they are all associated with message definition and fields, so they don't belong at the end of the doc. I am not sure whether versioning should go under message definition - it does contain field information. But since its a bigger topic, and new, its at the top level still. Merging now - if you think this was a mistake we can revert :-) |
@mrpollo I assume @GuillaumeLaine would like to volunteer. If not, I can help next week. |
|
I can also help. Guillaume should be back next week. |
|
@mrpollo I'm can help if there's anything I can do |
|
@GuillaumeLaine lets coordinate on discord |
This documents the newly versioned subset of PX4 messages, and the ROS 2 translation node that enables seamless communication between PX4 and ROS 2 applications that may be using different message definition versions.
Related Work
To Do
TODOs in the markdown of this PR