fix(mavlink): remove stale mavlink_tests add_subdirectory from CMakeLists#26740
Merged
fix(mavlink): remove stale mavlink_tests add_subdirectory from CMakeLists#26740
Conversation
a8baacc to
ffaf1bb
Compare
The mavlink_tests module was deleted in 1009268 but several references were left behind, breaking builds on all targets. Removed: - CMakeLists.txt: add_subdirectory(mavlink_tests) - mavlink_ftp.cpp: #include of deleted mavlink_ftp_test.h - mavlink_ftp.h: MavlinkFtpTest forward decl and friend class - posix-configs/SITL/init/test/test_mavlink: dead init script - sitl_tests.cmake: sitl-mavlink CTest target - install-voxl.sh: px4-mavlink_tests symlink Ref: #26738 Signed-off-by: Ramon Roche <mrpollo@gmail.com>
ffaf1bb to
099998d
Compare
Contributor
Author
|
Self-merging to fix main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add_subdirectory(mavlink_tests)fromsrc/modules/mavlink/CMakeLists.txtmavlink_tests/directory was deleted in 1009268 but this reference was not removed, breaking all SITL buildsTest plan
make px4_sitl_default)Ref: #26738