Skip to content

[backport] v1.16 fix gazebo install on ROS integration tests#25344

Merged
dakejahl merged 2 commits intorelease/1.16from
mrpollo/116_fix_gazebo
Aug 5, 2025
Merged

[backport] v1.16 fix gazebo install on ROS integration tests#25344
dakejahl merged 2 commits intorelease/1.16from
mrpollo/116_fix_gazebo

Conversation

@mrpollo
Copy link
Copy Markdown
Contributor

@mrpollo mrpollo commented Jul 31, 2025

Fixes the gazebo install for the ROS integration tests

@mrpollo mrpollo requested a review from dakejahl July 31, 2025 17:40
@mrpollo
ci: update rosdistro apt keys (#25060)
e3f7882 
Signed-off-by: Ramon Roche <mrpollo@gmail.com>
@mrpollo mrpollo force-pushed the mrpollo/116_fix_gazebo branch from 236d69b to e3f7882 Compare July 31, 2025 17:41
@mrpollo mrpollo mentioned this pull request Jul 31, 2025
Merged
@dakejahl
Copy link
Copy Markdown
Contributor

dakejahl commented Jul 31, 2025

CI failure is real

Starting >>> px4_ros2_cpp
--- stderr: px4_ros2_cpp
In file included from /opt/px4_ws/src/px4-ros2-interface-lib/px4_ros2_cpp/src/control/setpoint_types/fixedwing_lateral_longitudinal.cpp:6:
/opt/px4_ws/src/px4-ros2-interface-lib/px4_ros2_cpp/include/px4_ros2/control/setpoint_types/fixedwing_lateral_longitudinal.hpp:8:10: fatal error: px4_msgs/msg/fixed_wing_lateral_setpoint.hpp: No such file or directory
    8 | #include <px4_msgs/msg/fixed_wing_lateral_setpoint.hpp>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

@mrpollo
Copy link
Copy Markdown
Contributor Author

mrpollo commented Jul 31, 2025

I guess the gazebo failure was hiding this issue, we gotta get this fixed

@mrpollo
Copy link
Copy Markdown
Contributor Author

mrpollo commented Jul 31, 2025

@bkueng any idea where this is coming from?

@bkueng
Copy link
Copy Markdown
Member

bkueng commented Aug 5, 2025

Those messages got added after the 1.16 release. There's a matching release branch that we need to use for the integration tests. I added a change for that in 476a8b8. Let's see if it passes now.

@sansha
Copy link
Copy Markdown
Contributor

sansha commented Aug 5, 2025

Test passes now! 😍

@dakejahl dakejahl merged commit 6ea3539 into release/1.16 Aug 5, 2025
33 checks passed
@dakejahl dakejahl deleted the mrpollo/116_fix_gazebo branch August 5, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dakejahl dakejahl dakejahl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mrpollo @dakejahl @bkueng @sansha