mc_att_control: copy sensor_correction topic once initially#10830
Closed
RomanBapst wants to merge 1 commit intostablefrom
Closed
mc_att_control: copy sensor_correction topic once initially#10830RomanBapst wants to merge 1 commit intostablefrom
RomanBapst wants to merge 1 commit intostablefrom
Conversation
Signed-off-by: Roman <bapstroman@gmail.com>
Member
|
We need to be more deliberate when putting things directly into stable. If the tag isn't also updated then QGC users will get a bogus dev version as well as warnings. |
Contributor
Author
|
@dagar against what do you want me to do this PR? Also do you know why CI is failing? I can't get rid of the 404. |
Member
|
Can you fix it in master first, then backport it to stable? We need to tag it at the same time it goes into the stable branch. |
Contributor
Author
Member
|
Right okay. 2fe5e77#diff-14d11b3fe5440be3f4a64b36f55287ad Then let's get this into stable and tag it v1.8.2 |
Member
|
Cherry-picked to stable and tagged v1.8.2. https://github.com/PX4/Firmware/releases/tag/untagged-940aa5982d784e87171c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was causing the mc_att_controller and the sensors module not to be in sync after a reboot regarding which instance of the gyro topic was selected.
This is relevant when using the CAL_GYROx_EN parameters to disable a specific IMU.