Quote PYTHON_PATH command invocations in check_python() to handle spaced paths#1
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/PStarH/hermes-agent/sessions/46e368ba-909d-4ef0-86e1-0ad108a48acd Co-authored-by: PStarH <176644217+PStarH@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
PStarH
April 15, 2026 02:47
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_python()could fail on macOS whenPYTHON_PATHcontains spaces (e.g.,Library/Application Support/...) because unquoted variable expansion split the executable path during--versioncalls. This updates the function to consistently treat resolved Python paths as single tokens in assignment and execution contexts.Path-safe command execution
PYTHON_PATHcommand invocations in double quotes.uv path resolution hardening
PYTHON_PATH="$("$UV_CMD" python find "$PYTHON_VERSION" 2>/dev/null)"Scope
check_python(); no functional logic changes to detection/install flow.